Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On burn failure, return immediately before clean_state #2521

Merged
merged 1 commit into from
Jul 9, 2023
Merged

On burn failure, return immediately before clean_state #2521

merged 1 commit into from
Jul 9, 2023

Conversation

maxpkatz
Copy link
Member

@maxpkatz maxpkatz commented Jul 9, 2023

PR summary

clean_state will abort in normalize_species() if the burn failed and left things in an unphysical situation, but we don't want to abort in this circumstance because the next step is to reject the advance and try again. So we avoid this by skipping the call to clean_state if we're going to be rejecting the advance.

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@maxpkatz maxpkatz marked this pull request as ready for review July 9, 2023 12:47
@zingale zingale merged commit 9dff540 into AMReX-Astro:development Jul 9, 2023
13 of 14 checks passed
@maxpkatz maxpkatz deleted the move_burn_failure_return branch July 9, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zingale zingale zingale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxpkatz @zingale