Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a bit more to the abundance failure FAQ #2517

Merged
merged 2 commits into from
Jul 4, 2023
Merged

add a bit more to the abundance failure FAQ #2517

merged 2 commits into from
Jul 4, 2023

Conversation

zingale
Copy link
Member

@zingale zingale commented Jul 4, 2023

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale zingale merged commit c0cc597 into AMReX-Astro:development Jul 4, 2023
14 checks passed
@zingale zingale deleted the update_faq branch July 4, 2023 16:55
maxpkatz pushed a commit to maxpkatz/Castro that referenced this pull request Jul 4, 2023
@zingale @maxpkatz
add a bit more to the abundance failure FAQ (AMReX-Astro#2517)
1396465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpkatz maxpkatz maxpkatz approved these changes

Assignees
No one assigned
Labels
documentation 📖
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @maxpkatz