Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lochness update to accommodate the new Penn CNB REDCap structure #124

Open
wants to merge 3 commits into
base: kcho/pronet
Choose a base branch
from

Conversation

kcho
Copy link
Member

@kcho kcho commented Aug 31, 2023

The main change in the new Penn CNB REDCap is the new field name that contains AMP-SCZ IDs. (src_subject_id, which was session_subid in the previous CNB REDCap) This PR updates the field name.

Note that this PR will change the structure of UPENN JSON files, thus all downstream pipelines depending on the previous json structure need to be updated. An example of the new JSON file is located on ERIS:

/data/predict1/home/kcho/tmp/upenn_new_format/test_one_subject.json

(Deploying this PR will make the lochness instance to overwrite all existing UPENN JSON files.)

Copy link

@tashrifbillah tashrifbillah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was simple to review. This block will need update according to this PR:

https://github.com/AMP-SCZ/utility/blob/61321ccbcb5c34d61ab18baab2d2adb91705c671/subject_files_status_for_dpdash1.py#L287-L298

@kcho
Copy link
Member Author

kcho commented Sep 2, 2023

Thanks. I'll merge this PR and deploy it on Pronet server, once DPACC team agrees to move to the new PennCNB format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants