Ensure participant properties at site metadata #658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elkrival
changed the title
JackVCurtis
approved these changes
Mar 4, 2024
JackVCurtis
reviewed
Mar 4, 2024
| $addToSet: { | ||
| participants: { | ||
| Active: 1, | ||
| Consent: new Date(), |
There was a problem hiding this comment.
Should this be a date from the metadata, or do we track consent based on upload date?
WMahoney09
reviewed
Mar 4, 2024
Comment on lines
+78
to
+84
| participants: { | ||
| Active: 1, | ||
| Consent: new Date(), | ||
| study, | ||
| participant, | ||
| synced: new Date(), | ||
| }, |
There was a problem hiding this comment.
does it matter that participants is no longer a participant, but now contains a participant?
Thinking of a scenario where something like participants.name used to work, but now it would need to be participants.participant.name
can/should we spread participant?
Suggested change
| participants: { | |
| Active: 1, | |
| Consent: new Date(), | |
| study, | |
| participant, | |
| synced: new Date(), | |
| }, | |
| participants: { | |
| Active: 1, | |
| Consent: new Date(), | |
| study, | |
| synced: new Date(), | |
| ...participant, | |
| }, |
Also just based on participants being plural, should this be an array of participant objects?
|
closing because this will be handled in #665 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #661
This pr ensures that the participant that is stored has all the properties to render