Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #71

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Saransh1Sharma
Copy link

No description provided.

@@ -31,6 +31,7 @@ Lines starting with `*` are automatically rendered as bullet points and phrases
* Nevin Valsaraj [routeaccess](http://github.com/routeaccess)
* Prabhat Agarwal [prabhat1081](http://github.com/prabhat1081)
* Priyank Palod [priyankpalod](https://github.com/priyankpalod)
* Saransh Sharma [Saransh1Sharma] (http://github.com/Saransh1Sharma)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saransh1Sharma There isn't supposed to be a space between your username and url.
Also, please avoid writing a generic commit message.

@shivamvats shivamvats mentioned this pull request Mar 7, 2015
@krishna95
Copy link
Contributor

@Saransh1Sharma Please change your commit message

@krishna95
Copy link
Contributor

@Saransh1Sharma Your name is not in the final list because your PR isn't merged yet. Change the commit message using git commit --amend and your PR will be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants