Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about ReportSenderException #1362

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Conversation

GregCornis
Copy link
Contributor

acra-http throws a ReportSenderException if it fails to send the report, so I imagine it's a mechanism to allow for a later retry. ACRA's message is pretty clear: org.acra.sender.ReportSenderException: Policy marked this task as incomplete. ACRA will try to send this report again.

I thought it would be nice to document it. It might need to be rephrased.

@F43nd1r
Copy link
Member

F43nd1r commented Jun 25, 2024

Depending on the RetryPolicy, the sentence you added might not be true. Default behaviour is to only retry when all senders failed.
Of course most setups will only use one sender and the default policy, in which case your statement is true.

@GregCornis
Copy link
Contributor Author

How about

You can implement your own ReportSender and configure ACRA to use that instead of or in addition to other senders. Note: Throwing a ReportSenderException from YourCustomSender.send() notifies ACRA of a failed delivery, and might trigger a retry (see RetryPolicy).

@F43nd1r F43nd1r merged commit 2e0be5e into ACRA:master Aug 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants