Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipboy #187

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Pipboy #187

wants to merge 3 commits into from

Conversation

carterfromsl
Copy link

@carterfromsl carterfromsl commented Oct 4, 2023

New Stylesheet Submission:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other files using the same name as yours?
  • Have you filled in at least the required data for title, author, and stylesheet?
  • Is the value of stylesheet a full URL that is publicly accessible and renders an unminified, compiled CSS file?
  • Do your styles pass proper contrast for accessibility?
  • Have you included @media (prefers-reduced-motion: reduce) to remove animations on *,*::before,*::after?
  • Did you style the .skip-link?
  • Have you checked on a real mobile device to ensure your responsive design doesn't cause overlaps or overflow scrolling?

"Inspired by the iconic amber terminal display of Fallout: New Vegas, this design evokes nostalgic vibes of navigating the Mojave Desert."

Apologies for the lack of comments and the stream-of-consciousness vibe to the stylesheet. If you'd prefer a more structured approach, let me know and I can reorganize it to be more tidy. Otherwise, I've got this covered and can maintain as is.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

👋 Thanks for participating! I will review as soon as possible, usually within a few hours.

Watch for notifications as I may request some small changes to make sure this meets the guidelines.

In a few minutes, the Netlify process at the end of this PR will make a preview available. Look for the message "Deploy preview ready!" then click the "Details" link next to it to launch a preview of your styles. Make changes if needed, and comment if you do so I can re-deploy the preview. Note that the "sponsor footer" is not available to fully style, but you may fix any issues it causes to your layout.

Thanks again, I hope you learned something while making your stylesheet! 💫

@github-actions github-actions bot added the problem detected Bot has detected an potential problem with the submission label Oct 4, 2023
@5t3ph
Copy link
Owner

5t3ph commented Oct 28, 2023

Hey @carterfromsl - I really enjoyed the unique style here!

The biggest issue to resolve is lack of distinguishable focus styles. To test, please tab around your design and fix any place you don't see a visible focus (adding back outlines is the easiest).

Let me know when you've updated your styles, and I'll rebuild the preview for another review.

@carterfromsl
Copy link
Author

Thanks so much, @5t3ph !

I've updated the CodePen to add a more distinguishable focus with a black and amber box shadow and a thin inset outline to form a striped border.

Let me know if there's anything else I can do to improve it!

@carterfromsl
Copy link
Author

Hey again, @5t3ph !
Is there anything else I should add or change to get this stylesheet accepted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem detected Bot has detected an potential problem with the submission stylesheet submission
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants