Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylesheet submission: "Seifuku" #171

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

peterhohk
Copy link

New Stylesheet Submission:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other files using the same name as yours?
  • Have you filled in at least the required data for title, author, and stylesheet?
  • Is the value of stylesheet a full URL that is publicly accessible and renders an unminified, compiled CSS file?
  • Do your styles pass proper contrast for accessibility?
  • Have you included @media (prefers-reduced-motion: reduce) to remove animations on *,*::before,*::after?
  • Did you style the .skip-link?
  • Have you checked on a real mobile device to ensure your responsive design doesn't cause overlaps or overflow scrolling?

Thanks for the opportunity! Did I do this right? This is my first time participating in an open source project.

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

👋 Thanks for participating! I will review as soon as possible, usually within a few hours.

Watch for notifications as I may request some small changes to make sure this meets the guidelines.

In a few minutes, the Netlify process at the end of this PR will make a preview available. Look for the message "Deploy preview ready!" then click the "Details" link next to it to launch a preview of your styles. Make changes if needed, and comment if you do so I can re-deploy the preview. Note that the "sponsor footer" is not available to fully style, but you may fix any issues it causes to your layout.

Thanks again, I hope you learned something while making your stylesheet! 💫

@github-actions github-actions bot added problem detected Bot has detected an potential problem with the submission stylesheet submission labels Jul 2, 2023
@5t3ph
Copy link
Owner

5t3ph commented Oct 28, 2023

Hi @peterhohk - this is really fun!

Just one minor issue to address which is the color contrast for all of your links on hover/focus - the yellow is much too light against the background, it needs to continue meeting 4.5:1 contrast

Example:
image

Once you have updated your external stylesheet, let me know and I will rebuild the preview for review.

@peterhohk
Copy link
Author

peterhohk commented Oct 29, 2023

Hi @5t3ph,

I've pushed a fix for the issue. Please let me know if there are other problems.

(Side note: I thought aXe would've picked up contrast issues like this? Maybe it didn't consider hover/focus states. I didn't think to check manually because it "looked good to me".)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem detected Bot has detected an potential problem with the submission stylesheet submission
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants