test: add msg and refresh for coverage test #3413

vagetablechicken · 2023-07-31T10:35:08Z

No description provided.

codecov · 2023-07-31T10:57:17Z

Codecov Report

Patch coverage: 58.33% and project coverage change: +0.01% 🎉

Comparison is base (1b8d596) 75.33% compared to head (4159695) 75.34%.
Report is 8 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #3413      +/-   ##
============================================
+ Coverage     75.33%   75.34%   +0.01%     
  Complexity      414      414              
============================================
  Files           707      707              
  Lines        128428   128442      +14     
  Branches       1191     1191              
============================================
+ Hits          96751    96775      +24     
+ Misses        31436    31426      -10     
  Partials        241      241

Files Changed	Coverage Δ
src/client/tablet_client.cc	`58.41% <0.00%> (-0.58%)`	⬇️
src/nameserver/name_server_impl.cc	`44.93% <ø> (+0.16%)`	⬆️
src/nameserver/name_server_impl.h	`100.00% <ø> (ø)`
src/tablet/tablet_impl.cc	`65.34% <62.50%> (-0.08%)`	⬇️
src/cmd/sql_cmd_test.cc	`98.70% <100.00%> (+<0.01%)`	⬆️
src/tablet/sql_cluster_availability_test.cc	`93.98% <100.00%> (+0.02%)`	⬆️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2023-07-31T11:15:53Z

Linux Test Report

      57 files ±0     234 suites ±0 1h 12m 1s ⏱️ - 3m 15s
12 083 tests ±0 12 076 ✔️ ±0 7 💤 ±0 0 ❌ ±0
17 145 runs ±0 17 138 ✔️ ±0 7 💤 ±0 0 ❌ ±0

Results for commit 4159695. ± Comparison against base commit 1b8d596.

♻️ This comment has been updated with latest results.

github-actions · 2023-07-31T11:17:16Z

SDK Test Report

  98 files ±0   98 suites ±0 1m 58s ⏱️ -29s
222 tests ±0 209 ✔️ ±0 13 💤 ±0 0 ❌ ±0
269 runs ±0 256 ✔️ ±0 13 💤 ±0 0 ❌ ±0

Results for commit 4159695. ± Comparison against base commit 1b8d596.

This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.

  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
 ) limit 10;](2)
 ) limit 10;](3)
 FROM db1.t1
 FROM t1
 WINDOW w1 AS (
 last join db2.t2 order by db2.t2.col1
…

com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[db1,  SELECT sum(t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[null,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](4)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db1.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: db1.t2.str1](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.col1](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.str1](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[null, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](5)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlWindowLastJoin[ SELECT sum(t1.col1) over w1 as sum_t1_col1, t2.str1 as t2_str1
 FROM t1
 last join t2 order by t2.col1
 on t1.col1 = t2.col1 and t1.col2 = t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)

♻️ This comment has been updated with latest results.

github-actions · 2023-08-01T03:21:07Z

src/cmd/sql_cmd_test.cc

        // helpful for debug
+        // TODO if refresh is not good, sleep more


[cpplint] _{reported by reviewdog 🐶}
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]

github-actions · 2023-08-01T03:21:07Z

src/tablet/tablet_impl.cc

@@ -553,8 +553,13 @@ void TabletImpl::Refresh(RpcController* controller, const ::openmldb::api::Refre
                         ::openmldb::api::GeneralResponse* response, Closure* done) {
    brpc::ClosureGuard done_guard(done);
    if (IsClusterMode()) {
-        if (RefreshSingleTable(request->tid())) {
-            PDLOG(INFO, "refresh success. tid %u", request->tid());
+        if(request->has_tid()) {


[cpplint] _{reported by reviewdog 🐶}
Missing space before ( in if( [whitespace/parens] [5]

github-actions · 2023-08-01T04:51:02Z

src/cmd/sql_cmd_test.cc

@@ -2998,8 +2998,12 @@ TEST_P(DBSDKTest, LongWindowsCleanup) {
        HandleSQL("create database test2;");
        HandleSQL("use test2;");
        HandleSQL(create_sql);
+        sleep(5);
+        // TODO if refresh is not good, sleep more


[cpplint] _{reported by reviewdog 🐶}
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]

github-actions · 2023-08-01T04:51:02Z

src/tablet/tablet_impl.cc

@@ -5219,6 +5224,7 @@ void TabletImpl::CreateProcedure(RpcController* controller, const openmldb::api:
    const std::string& db_name = sp_info.db_name();
    const std::string& sp_name = sp_info.sp_name();
    const std::string& sql = sp_info.sql();
+    LOG(INFO) << "create procedure rpc in " << endpoint_; // no get size func << " with sp cache " << sp_cache_->


[cpplint] _{reported by reviewdog 🐶}
At least two spaces is best between code and comments [whitespace/comments] [2]

github-actions · 2023-08-01T04:51:02Z

src/tablet/tablet_impl.cc

@@ -5283,7 +5289,7 @@

    response->set_code(::openmldb::base::ReturnCode::kOk);
    response->set_msg("ok");
-    LOG(INFO) << "create procedure success! sp_name: " << sp_name << ", db: " << db_name << ", sql: " << sql;
+    LOG(INFO) << "create procedure success! sp_name: " << sp_name << ", db: " << db_name << ", sql: " << sql << " on " << endpoint_;


[cpplint] _{reported by reviewdog 🐶}
Lines should be <= 120 characters long [whitespace/line_length] [2]

vagetablechicken · 2023-08-21T11:22:29Z

https://github.com/4paradigm/OpenMLDB/actions/runs/5737110908/job/15969999175?pr=3413 check it

…t-high-freq

github-actions · 2023-08-24T11:12:46Z

src/tablet/tablet_impl.cc

@@ -5222,7 +5227,8 @@ void TabletImpl::CreateProcedure(RpcController* controller, const openmldb::api:
    if (sp_cache_->ProcedureExist(db_name, sp_name)) {
        response->set_code(::openmldb::base::ReturnCode::kProcedureAlreadyExists);
        response->set_msg("store procedure already exists");
-        PDLOG(WARNING, "store procedure[%s] already exists in db[%s]", sp_name.c_str(), db_name.c_str());
+        // print endpoint for ut debug
+        PDLOG(WARNING, "store procedure[%s] already exists in db[%s] on %s", sp_name.c_str(), db_name.c_str(), endpoint_.c_str());


[cpplint] _{reported by reviewdog 🐶}
Lines should be <= 120 characters long [whitespace/line_length] [2]

github-actions · 2023-08-24T11:12:46Z

src/tablet/tablet_impl.cc

@@ -5311,7 +5317,7 @@
    }
    response->set_code(::openmldb::base::ReturnCode::kOk);
    response->set_msg("ok");
-    PDLOG(INFO, "drop procedure success. db_name[%s] sp_name[%s]", db_name.c_str(), sp_name.c_str());
+    PDLOG(INFO, "drop procedure success. db_name[%s] sp_name[%s] on %s", db_name.c_str(), sp_name.c_str(), endpoint_.c_str());


[cpplint] _{reported by reviewdog 🐶}
Lines should be <= 120 characters long [whitespace/line_length] [2]

test: add msg and refresh for coverage test

5f58f70

vagetablechicken linked an issue Jul 31, 2023 that may be closed by this pull request

coverage fails at high freq #3412

Open

github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jul 31, 2023

debug

a0c3658

github-actions bot reviewed Aug 1, 2023

View reviewed changes

debug

a92aa00

github-actions bot reviewed Aug 1, 2023

View reviewed changes

vagetablechicken added 5 commits August 1, 2023 14:32

debug

2245adb

debug

acea6a6

debug

d6bb1d3

debug

c072f50

add debug info

f9baf0a

vagetablechicken added 2 commits August 24, 2023 18:58

Merge remote-tracking branch 'origin/main' into 3412-coverage-fails-a…

20460e2

…t-high-freq

debug msg

4159695

github-actions bot reviewed Aug 24, 2023

View reviewed changes

vagetablechicken mentioned this pull request Feb 20, 2024

sql_cmd_test too easy to fail #3751

Open

tobegit3hub assigned vagetablechicken Mar 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add msg and refresh for coverage test #3413

test: add msg and refresh for coverage test #3413

vagetablechicken commented Jul 31, 2023

codecov bot commented Jul 31, 2023 •

edited

Loading

github-actions bot commented Jul 31, 2023 •

edited

Loading

github-actions bot commented Jul 31, 2023 •

edited

Loading

github-actions bot Aug 1, 2023

github-actions bot Aug 1, 2023

github-actions bot Aug 1, 2023

github-actions bot Aug 1, 2023

github-actions bot Aug 1, 2023

vagetablechicken commented Aug 21, 2023

github-actions bot Aug 24, 2023

github-actions bot Aug 24, 2023

		// helpful for debug
		// TODO if refresh is not good, sleep more

test: add msg and refresh for coverage test #3413

Are you sure you want to change the base?

test: add msg and refresh for coverage test #3413

Conversation

vagetablechicken commented Jul 31, 2023

codecov bot commented Jul 31, 2023 • edited Loading

Codecov Report

github-actions bot commented Jul 31, 2023 • edited Loading

Linux Test Report

github-actions bot commented Jul 31, 2023 • edited Loading

SDK Test Report

github-actions bot Aug 1, 2023

Choose a reason for hiding this comment

github-actions bot Aug 1, 2023

Choose a reason for hiding this comment

github-actions bot Aug 1, 2023

Choose a reason for hiding this comment

github-actions bot Aug 1, 2023

Choose a reason for hiding this comment

github-actions bot Aug 1, 2023

Choose a reason for hiding this comment

vagetablechicken commented Aug 21, 2023

github-actions bot Aug 24, 2023

Choose a reason for hiding this comment

github-actions bot Aug 24, 2023

Choose a reason for hiding this comment

codecov bot commented Jul 31, 2023 •

edited

Loading

github-actions bot commented Jul 31, 2023 •

edited

Loading

github-actions bot commented Jul 31, 2023 •

edited

Loading