Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cxx sdk): support multi-thread, fix package logic and quickstart #3334

Merged
merged 19 commits into from
Jul 12, 2023

Conversation

vagetablechicken
Copy link
Collaborator

@vagetablechicken vagetablechicken commented Jun 26, 2023

closes #3225

  • cxx lib is big, ~2G, so only cicd workflow build it, and macos is unsupported(see error in workflow file)
  • add a make option INSTALL_CXXSDK, if not, won't install include/ and lib/

@github-actions github-actions bot added build openmldb compiling and installing docker openmldb compile image or demo image storage-engine openmldb storage engine. nameserver & tablet labels Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (53724ed) 75.65% compared to head (4cd1684) 75.65%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3334      +/-   ##
============================================
- Coverage     75.65%   75.65%   -0.01%     
  Complexity      414      414              
============================================
  Files           692      692              
  Lines        125819   125963     +144     
  Branches       1189     1189              
============================================
+ Hits          95189    95296     +107     
- Misses        30389    30426      +37     
  Partials        241      241              
Impacted Files Coverage Δ
src/sdk/openmldb_api.cc 0.00% <0.00%> (ø)
src/sdk/openmldb_api.h 0.00% <0.00%> (ø)

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the workflow CICD related label Jun 26, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 26, 2023
@vagetablechicken vagetablechicken changed the title build(cxx): fix cxx lib package logic and quickstart feat(cxx sdk): support multi-thread, fix package logic and quickstart Jun 28, 2023
@vagetablechicken vagetablechicken marked this pull request as ready for review July 3, 2023 07:00
@vagetablechicken vagetablechicken merged commit 016c7f9 into 4paradigm:main Jul 12, 2023
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build openmldb compiling and installing docker openmldb compile image or demo image documentation Improvements or additions to documentation storage-engine openmldb storage engine. nameserver & tablet workflow CICD related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

c++ sdk static lib can't be used, Malformed archive
3 participants