Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refresh table info after zk updated #3328

Merged
merged 9 commits into from
Jun 26, 2023

Conversation

vagetablechicken
Copy link
Collaborator

cicd workflow cpp job failed on deploy, cuz tablet may overwrite index by old zk info(slow notify, and no version, so it replace new), so make tablet sync zk info after zk info update.

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 93.75% and project coverage change: -0.05 ⚠️

Comparison is base (bf4e614) 75.55% compared to head (1cd620b) 75.50%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3328      +/-   ##
============================================
- Coverage     75.55%   75.50%   -0.05%     
- Complexity      411      414       +3     
============================================
  Files           693      693              
  Lines        125974   126088     +114     
  Branches       1185     1189       +4     
============================================
+ Hits          95175    95200      +25     
- Misses        30561    30647      +86     
- Partials        238      241       +3     
Impacted Files Coverage Δ
src/nameserver/name_server_impl.h 100.00% <ø> (ø)
src/nameserver/name_server_impl.cc 44.89% <92.30%> (+0.02%) ⬆️
src/cmd/sql_cmd_test.cc 98.66% <100.00%> (-0.01%) ⬇️
src/test/util.cc 85.05% <100.00%> (ø)

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/test/util.cc Outdated Show resolved Hide resolved
@vagetablechicken vagetablechicken merged commit eb14873 into 4paradigm:main Jun 26, 2023
21 of 22 checks passed
@vagetablechicken vagetablechicken deleted the index-flush branch June 26, 2023 09:40
dl239 pushed a commit that referenced this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants