[WIP] Feature/multi robot #19
Conversation
…v variable within the new session i.e. for docker names
…th special chars.
fmessmer
force-pushed
the
feature/multi_robot
branch
from
b92fe86
to
db59c48
Compare
There was a problem hiding this comment.
maybe we should add a solution for https://github.com/4am-robotics/orga/issues/6838 to this PR, too
robmuxinator/robmuxinator.py
Outdated
| @@ -472,7 +472,7 @@ def __init__(self, ssh_client, session_name, yaml_session, envs=None) -> None: | |||
| command_env_prefix = "" | |||
| if self._envs is not None: | |||
| for env in self._envs: | |||
| command_env_prefix += "export {}={} && ".format(env[0], env[1]) | |||
| command_env_prefix += "export {}='{}' && ".format(env[0], env[1]) | |||
There was a problem hiding this comment.
I think this breaks something for our upstart files, i.e.:
PKG_NAV_ENV_CONFIG="'\$(find mojin_default_env_config)'"
will no longer be correctly passed to the tmux session...
@Odin-byte
do you remember the reason why this is important for you and the multi-robot usecase?
There was a problem hiding this comment.
I added this to correctly parse longer strings including special characters. If there is another solution to this problem, this is no longer needed.
There was a problem hiding this comment.
But I might just need to enclose longer strings in double quotes like your example to ensure correct parsing.
There was a problem hiding this comment.
can you give an example for a string that was problematic in you case?
There was a problem hiding this comment.
I believe it was longer strings like:
XAUTHORITY='/run/user/1000/.mutter-Xwaylandauth.I7PAU2'
There was a problem hiding this comment.
But I can image the simpler fix would be to add a pair of double quotes like you did above
ref https://github.com/4am-robotics/orga/issues/4389
ref https://github.com/4am-robotics/orga/issues/6785
modified version of #15
provided as new branch in order to not interfere with @Odin-byte thesis