Fix join and part/leave on replay #567
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hloeung
force-pushed
the
replay-join-part
branch
3 times, most recently
from
6ae4f02
to
cfacfdc
Compare
Without this, on matterircd reconnect & relay, users in channels can be out of sync. This causes issues with trying to auto-complete IRC nicks for example.
hloeung
force-pushed
the
replay-join-part
branch
from
cfacfdc
to
f63818e
Compare
|
Seems this will cause BIP IRC Proxy to crash, as in some cases, bip will try to add an already existing user to a channel user list it already had when receiving a I believe a server should only send PART / JOIN when it has sent a channel user list without the related change (like with NAMES or WHO commands). I'm not sure that's required per the RFC but I would expect the RFC to be strict about sending PART and JOIN messages when the result of such action is already visible in NAMES or WHO. I think this happened when I (or someone else) was forcefully added to a channel, bip received the full user list, and then a JOIN command. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, on matterircd reconnect & relay, users in channels can be out of sync. This causes issues with trying to auto-complete IRC nicks for example.