Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #1

Open
wants to merge 90 commits into
base: feedback
Choose a base branch
from
Open

Feedback #1

wants to merge 90 commits into from

Conversation

github-classroom[bot]
Copy link

@github-classroom github-classroom bot commented Sep 25, 2023

👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to main since the assignment started. Your teacher can see this too.

Notes for teachers

Use this PR to leave feedback. Here are some tips:

  • Click the Files changed tab to see all of the changes pushed to main since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.
  • Click the Commits tab to see the commits pushed to main. Click a commit to see specific changes.
  • If you turned on autograding, then click the Checks tab to see the results.
  • This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below.
    For more information about this pull request, read “Leaving assignment feedback in GitHub”.

Subscribed: @HachemBouhadede @ismail-benlaredj @liliumorion @SaraBegache @dalilia @merzoukfatima @Hxkim10 @meryem08

github-classroom bot and others added 30 commits September 25, 2023 17:29
refactor(project setup): setup & clean the project & add react icons …
…y to it

creat, build and display the slider for the homepage, with all of it's features

BREAKING CHANGE: we have something to look at in the home page

fix #6
enhance slider with autoplay, a filler href for its button, add homepage content with responsivness
(product list)

BREAKING CHANGE: homepage functional build is completed, onlly missing stuff are links

fix #6
remove map from productcard, add hover and size effects to it

fix #7
use getstaticprops and getstaticpath in fetch data nd links, currently displaying data as json

fix 18
…d cover picture, add routing

use the data fetched by getstaticprops to display a list of catagery items, implement a logic to get
a dynamic  cover picture, add the consts file (and i'm happy to say 0 chatGPT was used here)

BREAKING CHANGE: we have a categories page !

fix 18
HachemBouhadede and others added 6 commits October 3, 2023 06:27
…con, fix consol issue with LCP

add profile icon, directs to authentification, create authentification page with sign in and sign up
forms, after sign up or in, redirects to home page

BREAKING CHANGE: Authentification Succesfull

feat #26
…+global context,md nav display

add signout methode, conditional page rendring for authentificat and shopcart pages depending on
user state if logged in or out, conditional routing if sign in, sign up or sign out, add global
context for user state, adjust space betwn categories in navbar while in md

feat #26
feat(add env file): env to hide firebase api
@vercel
Copy link

vercel bot commented Oct 10, 2023

@HachemBouhadede is attempting to deploy a commit to the amazd Team on Vercel.

To accomplish this, @HachemBouhadede needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants