Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typeerror t is not a function #178

Merged
merged 6 commits into from
Nov 27, 2023
Merged

Fix typeerror t is not a function #178

merged 6 commits into from
Nov 27, 2023

Conversation

Ben-Tewfik
Copy link
Contributor

@Ben-Tewfik Ben-Tewfik commented Nov 27, 2023 •
edited
Loading

Pull Request Description:

In this pull request, I made the following changes:

  • Fixed TypeError: t is not a function
  • Added URL to profile dropdown
  • Fixed next config error
  • Translated Editprofile into Arabic and French
  • Added favicon title and description to the layout
  • Fixed the deletion of user info in Firestore when the form inputs are empty.

Screenshots:

Favicon:
image
Arabic translation:
image
French Translation:
image

Related Issue

@Ben-Tewfik Ben-Tewfik linked an issue Nov 27, 2023 that may be closed by this pull request
Fix TypeError: t is not a function #174
Closed
@vercel Vercel
Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
student-store ✅ Ready (Inspect) Visit Preview Nov 27, 2023 11:20am

@Ben-Tewfik Ben-Tewfik self-assigned this Nov 27, 2023
@Ben-Tewfik Ben-Tewfik added bug Something isn't working translation labels Nov 27, 2023
KatiaGhezali
KatiaGhezali approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@KatiaGhezali KatiaGhezali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the issue, it is working now.

hocine1212
hocine1212 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@hocine1212 hocine1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@hocine1212 hocine1212 merged commit 9cdfdfb into develop Nov 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KatiaGhezali KatiaGhezali KatiaGhezali approved these changes

@hocine1212 hocine1212 hocine1212 approved these changes

@samiba6 samiba6 Awaiting requested review from samiba6

@khaoulasara khaoulasara Awaiting requested review from khaoulasara

@MouniaBelkheir MouniaBelkheir Awaiting requested review from MouniaBelkheir

Assignees

@Ben-Tewfik Ben-Tewfik

Labels
bug Something isn't working translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix TypeError: t is not a function
3 participants
@Ben-Tewfik @KatiaGhezali @hocine1212