Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the hamburger menu styling #171

Merged
merged 14 commits into from
Nov 26, 2023
Merged

Improve the hamburger menu styling #171

merged 14 commits into from
Nov 26, 2023

Conversation

hocine1212
Copy link
Contributor

@hocine1212 hocine1212 commented Nov 26, 2023 •
edited
Loading

Pull Request : Improve the hamburger menu styling.

Description :

This pull request addresses the task "Improve the hamburger menu styling." The SidebarNB component has been refactored to enhance its visual appeal and user-friendliness. The styling has been revamped to create a more polished and intuitive appearance. Additionally, responsiveness has been ensured for different sizes.

Subtasks Completed

  • Refactored the styling of SidebarNB to improve visual aesthetics.
  • Ensured the consistency of styling across different screen sizes.
  • Implemented the logic to open the sidebar when the hamburger menu is clicked.
  • Implemented fixes to update and maintain the correct user state.
  • Implemented adjustments to the positioning of the search icon for better alignment.

Screenshots

English :

image

Arabic :

image

French :

image

Related Issue

@hocine1212
feat(sidebar.jsx): change the styling of the SideBarNB component
49ae3ec
@hocine1212
feat(sidebarnb.jsx): add the links and categories to the SideBarNB co…
9ef645f 
…mponent
@hocine1212
feat(sidebarnb.jsx): add the functionality to the categories submenu
5ee66e2
@hocine1212
feat(sidebarnb.jsx): implement Open and close Sidebar functionality
ab17b1e
@hocine1212
fix(sidebarnb.jsx): fix the SideBarNB behavior when clicking on links
72f7b81
@hocine1212
style(sidebarnb.jsx): delete unnecessary code
6234f52
@hocine1212
fix(sidebarnb.jsx): fix the direction Of the sidebar when the languag…
82cf65b 
…e is arabic
@hocine1212
fix(navbar and sidebarnb): fix the translation of some Links
901996d
@hocine1212
fix(app): fix user state in cart and listing page
d71462a
@hocine1212
fix(components): fix and Ajust the styling in some components
c6c6052
@hocine1212
Merge branch 'develop' of github.com:202306-NEA-DZ-FEW/StudentStore i…
665a82b 
…nto 166-improve-the-hamburger-menu-styling
@hocine1212
style(cart page): change the text color of the cart page title
b1930e3
@hocine1212
fix(app): resolve merge conflicts
202f021
@hocine1212
fix(searchbar.jsx): fix the position of the search icon when the lang…
68da734 
…uage is arabic
@hocine1212 hocine1212 linked an issue Nov 26, 2023 that may be closed by this pull request
Improve the hamburger menu styling #166
Closed
5 tasks
@vercel Vercel
Copy link

vercel bot commented Nov 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
student-store ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2023 10:44pm

@hocine1212 hocine1212 changed the title 166 improve the hamburger menu styling Improve the hamburger menu styling Nov 26, 2023
@hocine1212 hocine1212 self-assigned this Nov 26, 2023
@hocine1212 hocine1212 added bug Something isn't working enhancement New feature or request design Styling is involved labels Nov 26, 2023
Ben-Tewfik
Ben-Tewfik approved these changes Nov 26, 2023
View reviewed changes
Copy link
Contributor

@Ben-Tewfik Ben-Tewfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done

KatiaGhezali
KatiaGhezali approved these changes Nov 26, 2023
View reviewed changes
Copy link
Collaborator

@KatiaGhezali KatiaGhezali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hamburger menu looks nice and it is responsive, the code is clean as well.
The work is appreciated Hocine, thank you

@KatiaGhezali KatiaGhezali merged commit 0503b0e into develop Nov 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KatiaGhezali KatiaGhezali KatiaGhezali approved these changes

@Ben-Tewfik Ben-Tewfik Ben-Tewfik approved these changes

@samiba6 samiba6 Awaiting requested review from samiba6

@khaoulasara khaoulasara Awaiting requested review from khaoulasara

@MouniaBelkheir MouniaBelkheir Awaiting requested review from MouniaBelkheir

Assignees

@hocine1212 hocine1212

Labels
bug Something isn't working design Styling is involved enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the hamburger menu styling
3 participants
@hocine1212 @KatiaGhezali @Ben-Tewfik