Create OurTeam component #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samiba6
requested review from
KatiaGhezali,
hocine1212,
Ben-Tewfik,
khaoulasara and
MouniaBelkheir
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KatiaGhezali
requested changes
Nov 22, 2023
There was a problem hiding this comment.
Thank you for your effort Sami, however I have noticed some things that need to be fixed:
- The hover effect only works on large screens. In md and sm screens, you cannot see the team member information.
- There is still a slight delay when the cards open(Almost hard to notice).
- The color is beautiful, however not vert compatible with the palette we already have.
Please try to see to these little details, and again thank you for your work.
…nto 130-create-our-team-component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request implements the OurTeam component, enhancing the user interface of the Student's Store by introducing an engaging presentation of team members. The component displays team member details upon hover, showcasing their names, roles, and associated social links. This creates an interactive experience for users exploring our team.
Changes Made
Created the OurTeam component: OurTeam.js.
Integrated the OurTeam component into the About us page.
Added hover animations for displaying member details and social links.
Ensured responsiveness across various screen sizes.
Screenshots
For Large Screens
For Small screens
Related Issue
Resolves #130
Related Issue