Fix: call failure gas refund to caller #698
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
requested review from
wborgeaud,
muursh and
LindaGuiga
as code owners
github-actions
bot
added
the
crate: evm_arithmetization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon CALL failure, we refund the amount initially sent to the caller. However, during the call frame, the target
tomay have spent it all, being unable to refund fully the initialamount.We need to call
%min(initial_amount, current_balance)and withdraw this instead. This edge case unfortunately wasn't caught by the Ethereum test suite but got triggered in John's test (block 978, txn 43). Will consider adding it as regression payload once the whole block is passing.3/N @praetoriansentry