Fix trace decoder padding with dummy payloads #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BGluth
reviewed
Feb 26, 2024
| initial_tries: &PartialTrieState, | ||
| final_tries: &PartialTrieState, | ||
| has_withdrawals: bool, | ||
| ) -> bool { | ||
| match gen_inputs.len() { | ||
| 0 => { | ||
| debug_assert!(initial_tries.state == final_tries.state); | ||
| debug_assert!(initial_extra_data == final_extra_data); |
There was a problem hiding this comment.
nit: Do you think it's worth adding a error string for these? Might be overkill idk.
There was a problem hiding this comment.
I think the assertions are actually not needed here, as it's solely based on gen_inputs len, meaning the loop wouldn't have been entered before
BGluth
added a commit
that referenced
this pull request
Jun 17, 2024
Fixed txn proof logs not rendering correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were always using the final
ExtraBlockDatawhen padding a block. In the case of a single txn, when there are no withdrawals, we still prepend the txn with the dummy payload for efficiency, but this was leading to discrepancies when connecting the two.This fixes it.