Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mpt_trie missing docs #37

Merged
merged 6 commits into from
Feb 15, 2024
Merged

Add mpt_trie missing docs #37

merged 6 commits into from
Feb 15, 2024

Conversation

4l0n50
Copy link
Contributor

@4l0n50 4l0n50 commented Feb 15, 2024

No description provided.

@4l0n50 4l0n50 changed the title Add missing docs Add mpt_trie missing docs Feb 15, 2024
muursh
muursh reviewed Feb 15, 2024
View reviewed changes
mpt_trie/src/nibbles.rs Outdated Show resolved Hide resolved
muursh
muursh reviewed Feb 15, 2024
View reviewed changes
mpt_trie/src/nibbles.rs Outdated Show resolved Hide resolved
@Nashtare Nashtare added documentation Improvements or additions to documentation crate: mpt_trie Anything related to the mpt_trie crate. labels Feb 15, 2024
Nashtare
Nashtare approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @4l0n50! Just a few nits for consistency, but LGTM!

mpt_trie/src/nibbles.rs Outdated Show resolved Hide resolved
mpt_trie/src/debug_tools/stats.rs Outdated Show resolved Hide resolved
mpt_trie/src/nibbles.rs Outdated Show resolved Hide resolved
mpt_trie/src/debug_tools/query.rs Outdated Show resolved Hide resolved
mpt_trie/src/debug_tools/stats.rs Outdated Show resolved Hide resolved
@Nashtare Nashtare enabled auto-merge (squash) February 15, 2024 14:17
@Nashtare Nashtare merged commit e9dcb33 into 0xPolygonZero:main Feb 15, 2024
5 checks passed
BGluth added a commit that referenced this pull request Jun 17, 2024
@BGluth
Merge pull request #37 from 0xPolygonZero/testing_note_in_readme
f5a4c7e 
Added a section about branches and testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muursh muursh muursh approved these changes

@Nashtare Nashtare Nashtare approved these changes

Assignees

@4l0n50 4l0n50

Labels
crate: mpt_trie Anything related to the mpt_trie crate. documentation Improvements or additions to documentation
Projects
Zero EVM
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@4l0n50 @muursh @Nashtare