chg: solve some TODOs / fix some tests and provide context for skippe…

…d tests

x/auth/ante/ante_test.go

@@ -652,7 +652,7 @@ func TestAnteHandlerFees(t *testing.T) {
 
 // Test logic around memo gas consumption.
 func TestAnteHandlerMemoGas(t *testing.T) {
-	t.Skip("skipping test as not relevant to Heimdall")
+	t.Skip("skipping test as not relevant to Heimdall (no memo)")
 	testCases := []TestCase{
 		{
 			"tx does not have enough gas",
@@ -733,7 +733,7 @@ func TestAnteHandlerMemoGas(t *testing.T) {
 }
 
 func TestAnteHandlerMultiSigner(t *testing.T) {
-	t.Skip("skipping test as not relevant to Heimdall")
+	t.Skip("skipping test as not relevant to Heimdall (no multisign)")
 	feeAmount := testdata.NewTestFeeAmount()
 	gasLimit := testdata.NewTestGasLimit()
 
@@ -1385,7 +1385,7 @@ func TestCustomSignatureVerificationGasConsumer(t *testing.T) {
 }
 
 func TestAnteHandlerReCheck(t *testing.T) {
-	t.Skip() // TODO HV2: This test is currently broken. To be fixed?
+	t.Skip("skipping test as not relevant to Heimdall (no checkTx)")
 	suite := SetupTestSuite(t, false)
 	// Set recheck=true
 	suite.ctx = suite.ctx.WithIsReCheckTx(true)

x/auth/ante/basic_test.go

@@ -18,7 +18,7 @@ import (
 )
 
 func TestValidateBasic(t *testing.T) {
-	suite := SetupTestSuite(t, true)
+	suite := SetupTestSuite(t, false)
 	suite.txBuilder = suite.clientCtx.TxConfig.NewTxBuilder()
 
 	// keys and addresses
@@ -59,7 +59,7 @@ func TestValidateBasic(t *testing.T) {
 }
 
 func TestValidateMemo(t *testing.T) {
-	suite := SetupTestSuite(t, true)
+	suite := SetupTestSuite(t, false)
 	suite.txBuilder = suite.clientCtx.TxConfig.NewTxBuilder()
 
 	// keys and addresses
@@ -95,7 +95,7 @@ func TestValidateMemo(t *testing.T) {
 }
 
 func TestConsumeGasForTxSize(t *testing.T) {
-	suite := SetupTestSuite(t, true)
+	suite := SetupTestSuite(t, false)
 
 	// keys and addresses
 	priv1, _, addr1 := testdata.KeyTestPubAddr()
@@ -179,7 +179,7 @@ func TestConsumeGasForTxSize(t *testing.T) {
 }
 
 func TestTxHeightTimeoutDecorator(t *testing.T) {
-	suite := SetupTestSuite(t, true)
+	suite := SetupTestSuite(t, false)
 
 	antehandler := sdk.ChainAnteDecorators(ante.NewTxTimeoutHeightDecorator())
 

x/auth/ante/ext_test.go

@@ -13,7 +13,7 @@ import (
 )
 
 func TestRejectExtensionOptionsDecorator(t *testing.T) {
-	suite := SetupTestSuite(t, true)
+	suite := SetupTestSuite(t, false)
 
 	testCases := []struct {
 		msg   string

x/auth/ante/fee_test.go

@@ -18,7 +18,7 @@ import (
 )
 
 func TestDeductFeeDecorator_ZeroGas(t *testing.T) {
-	s := SetupTestSuite(t, true)
+	s := SetupTestSuite(t, false)
 	s.txBuilder = s.clientCtx.TxConfig.NewTxBuilder()
 
 	mfd := ante.NewDeductFeeDecorator(s.accountKeeper, s.bankKeeper, s.feeGrantKeeper, nil)
@@ -50,7 +50,7 @@ func TestDeductFeeDecorator_ZeroGas(t *testing.T) {
 }
 
 func TestEnsureMempoolFees(t *testing.T) {
-	t.Skip()                     // TODO HV2: skipped as we use a different fee model. To be fixed?
+	t.Skip("skipping test as not relevant to Heimdall (no checkTx")
 	s := SetupTestSuite(t, true) // setup
 	s.txBuilder = s.clientCtx.TxConfig.NewTxBuilder()
 

x/auth/ante/setup_test.go

@@ -17,7 +17,7 @@ import (
 )
 
 func TestSetupDecorator_BlockMaxGas(t *testing.T) {
-	suite := SetupTestSuite(t, true)
+	suite := SetupTestSuite(t, false)
 	suite.txBuilder = suite.clientCtx.TxConfig.NewTxBuilder()
 
 	// keys and addresses
@@ -51,7 +51,7 @@ func TestSetupDecorator_BlockMaxGas(t *testing.T) {
 }
 
 func TestSetup(t *testing.T) {
-	suite := SetupTestSuite(t, true)
+	suite := SetupTestSuite(t, false)
 	suite.txBuilder = suite.clientCtx.TxConfig.NewTxBuilder()
 
 	// keys and addresses
@@ -86,7 +86,7 @@ func TestSetup(t *testing.T) {
 }
 
 func TestRecoverPanic(t *testing.T) {
-	suite := SetupTestSuite(t, true)
+	suite := SetupTestSuite(t, false)
 	suite.txBuilder = suite.clientCtx.TxConfig.NewTxBuilder()
 
 	// keys and addresses

x/auth/ante/sigverify_test.go

@@ -29,7 +29,7 @@ import (
 )
 
 func TestSetPubKey(t *testing.T) {
-	suite := SetupTestSuite(t, true)
+	suite := SetupTestSuite(t, false)
 	suite.txBuilder = suite.clientCtx.TxConfig.NewTxBuilder()
 
 	// keys and addresses
@@ -71,7 +71,7 @@ func TestSetPubKey(t *testing.T) {
 }
 
 func TestConsumeSignatureVerificationGas(t *testing.T) {
-	suite := SetupTestSuite(t, true)
+	suite := SetupTestSuite(t, false)
 	params := types.DefaultParams()
 	msg := []byte{1, 2, 3, 4}
 
@@ -125,7 +125,7 @@ func TestConsumeSignatureVerificationGas(t *testing.T) {
 }
 
 func TestSigVerification(t *testing.T) {
-	suite := SetupTestSuite(t, true)
+	suite := SetupTestSuite(t, false)
 	suite.txBankKeeper.EXPECT().DenomMetadata(gomock.Any(), gomock.Any()).Return(&banktypes.QueryDenomMetadataResponse{}, nil).AnyTimes()
 
 	enabledSignModes := []signing.SignMode{signing.SignMode_SIGN_MODE_DIRECT, signing.SignMode_SIGN_MODE_TEXTUAL, signing.SignMode_SIGN_MODE_LEGACY_AMINO_JSON}
@@ -262,7 +262,7 @@ func TestSigIntegration(t *testing.T) {
 }
 
 func runSigDecorators(t *testing.T, params types.Params, _ bool, privs ...cryptotypes.PrivKey) (storetypes.Gas, error) {
-	suite := SetupTestSuite(t, true)
+	suite := SetupTestSuite(t, false)
 	suite.txBuilder = suite.clientCtx.TxConfig.NewTxBuilder()
 
 	// Make block-height non-zero to include accNum in SignBytes
@@ -311,7 +311,7 @@ func runSigDecorators(t *testing.T, params types.Params, _ bool, privs ...crypto
 }
 
 func TestIncrementSequenceDecorator(t *testing.T) {
-	suite := SetupTestSuite(t, true)
+	suite := SetupTestSuite(t, false)
 	suite.txBuilder = suite.clientCtx.TxConfig.NewTxBuilder()
 
 	priv, _, addr := testdata.KeyTestPubAddr()

x/auth/keeper/deterministic_test.go

@@ -145,7 +145,6 @@ func pubkeyGenerator(t *rapid.T) *rapid.Generator[secp256k1.PubKey] {
 }
 
 func (suite *DeterministicTestSuite) TestGRPCQueryAccounts() {
-	suite.T().Skip()
 	rapid.Check(suite.T(), func(t *rapid.T) {
 		numAccs := rapid.IntRange(1, 10).Draw(t, "accounts")
 		accs := suite.createAndSetAccounts(t, numAccs)
@@ -198,7 +197,6 @@ func (suite *DeterministicTestSuite) TestGRPCQueryAccountAddressByID() {
 }
 
 func (suite *DeterministicTestSuite) TestGRPCQueryParameters() {
-	// suite.T().Skip() // TODO HV2: skipped as we use a different fee model. To be fixed?
 	rapid.Check(suite.T(), func(t *rapid.T) {
 		params := types.NewParams(
 			rapid.Uint64Min(1).Draw(t, "max-memo-characters"),

x/auth/migrations/v2/store_test.go

@@ -46,7 +46,7 @@ func (ms mockSubspace) GetParamSet(ctx sdk.Context, ps authexported.ParamSet) {
 }
 
 func TestMigrateVestingAccounts(t *testing.T) {
-	t.Skip() // TODO HV2: skipped as it uses depinject. Shall we enable it and unskip this test?
+	t.Skip("skipping test as not relevant to Heimdall (no depinject)") // TODO HV2: setup app without depinject and enable it?
 	encCfg := moduletestutil.MakeTestEncodingConfig(auth.AppModuleBasic{})
 	cdc := encCfg.Codec
 

x/auth/migrations/v3/store_test.go

@@ -42,7 +42,7 @@ func (ms mockSubspace) GetParamSet(ctx sdk.Context, ps authexported.ParamSet) {
 
 // TestMigrateMapAccAddressToAccNumberKey test cases for state migration of map to accAddr to accNum
 func TestMigrateMapAccAddressToAccNumberKey(t *testing.T) {
-	t.Skip() // TODO HV2: skipped as it uses depinject. Shall we enable it and unskip this test?
+	t.Skip("skipping test as not relevant to Heimdall (no depinject)") // TODO HV2: setup app without depinject and enable it?
 	encCfg := moduletestutil.MakeTestEncodingConfig(auth.AppModuleBasic{})
 	cdc := encCfg.Codec
 

x/auth/module_test.go

@@ -15,7 +15,7 @@ import (
 )
 
 func TestItCreatesModuleAccountOnInitBlock(t *testing.T) {
-	t.Skip() // skipping as we are not using depinject
+	t.Skip("skipping test as not relevant to Heimdall (no depinject)") // TODO HV2: setup app without depinject and enable it?
 	var accountKeeper keeper.AccountKeeper
 	app, err := simtestutil.SetupAtGenesis(
 		depinject.Configs(

x/auth/types/account_retriever_test.go

@@ -11,7 +11,7 @@ import (
 )
 
 func TestAccountRetriever(t *testing.T) {
-	t.Skip() // TODO HV2: skipped as it uses depinject. Shall we enable it and unskip this test?
+	t.Skip("skipping test as not relevant to Heimdall (no depinject)") // TODO HV2: setup app without depinject and enable it?
 	cfg, err := network.DefaultConfigWithAppConfig(testutil.AppConfig)
 	require.NoError(t, err)
 	cfg.NumValidators = 1

x/auth/vesting/msg_server_test.go

@@ -68,7 +68,7 @@ func (s *VestingTestSuite) SetupTest() {
 }
 
 func (s *VestingTestSuite) TestCreateVestingAccount() {
-	s.T().Skip() // skipped as not using vesting accounts
+	s.T().Skip("skipping test as not relevant to Heimdall (no vesting)")
 	testCases := map[string]struct {
 		preRun    func()
 		input     *vestingtypes.MsgCreateVestingAccount
@@ -187,7 +187,7 @@ func (s *VestingTestSuite) TestCreateVestingAccount() {
 }
 
 func (s *VestingTestSuite) TestCreatePermanentLockedAccount() {
-	s.T().Skip() // skipped as not using vesting accounts
+	s.T().Skip("skipping test as not relevant to Heimdall (no vesting)")
 	testCases := map[string]struct {
 		preRun    func()
 		input     *vestingtypes.MsgCreatePermanentLockedAccount
@@ -270,7 +270,7 @@ func (s *VestingTestSuite) TestCreatePermanentLockedAccount() {
 }
 
 func (s *VestingTestSuite) TestCreatePeriodicVestingAccount() {
-	s.T().Skip() // skipped as not using vesting accounts
+	s.T().Skip("skipping test as not relevant to Heimdall (no vesting)")
 	testCases := []struct {
 		name      string
 		preRun    func()