Rebase peppermint branch to v0.38.5 #2
Raneet10Annotations
10 errors and 7 warnings
|
golangci-lint:
libs/log/tm_logger.go#L67
Error return value of `(github.com/go-kit/log.Logger).Log` is not checked (errcheck)
|
|
golangci-lint:
scripts/metricsgen/metricsgen_test.go#L114
string `type Metrics struct {
|
|
golangci-lint:
libs/tempfile/tempfile_test.go#L70
string `/tmp/` has 4 occurrences, make it a constant (goconst)
|
|
golangci-lint:
p2p/key_test.go#L17
string `_peer_id.json` has 3 occurrences, make it a constant (goconst)
|
|
golangci-lint:
types/genesis_test.go#L31
string `"type":"tendermint/PubKeyEd25519","value":"AT/+aaL1eB0477Mud9JMm8Sh8BIvOYlPGC9KkIUmFaE="` has 3 occurrences, make it a constant (goconst)
|
|
golangci-lint:
types/genesis_test.go#L32
string `},"power":"10","name":""}` has 3 occurrences, make it a constant (goconst)
|
|
golangci-lint:
libs/pubsub/query/query_test.go#L306
string `tx|date=` has 3 occurrences, make it a constant (goconst)
|
|
|
|
golangci-lint:
state/txindex/kv/kv_test.go#L695
string `account.number < ` has 3 occurrences, make it a constant (goconst)
|
|
golangci-lint:
state/txindex/kv/kv_test.go#L686
string `account.number >= ` has 6 occurrences, make it a constant (goconst)
|
|
golangci-lint:
libs/protoio/io.go#L70
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
|
|
golangci-lint:
crypto/merkle/tree_test.go#L11
dot-imports: should not use dot imports (revive)
|
|
golangci-lint:
p2p/netaddress.go#L48
superfluous-else: if block ends with call to panic function, so drop this else and outdent its block (revive)
|
|
golangci-lint:
types/vote_set.go#L268
superfluous-else: if block ends with call to panic function, so drop this else and outdent its block (revive)
|
|
golangci-lint:
types/priv_validator.go#L155
unused-parameter: parameter 'data' seems to be unused, consider removing or renaming it as _ (revive)
|
|
golangci-lint:
privval/signer_client.go#L136
unused-parameter: parameter 'data' seems to be unused, consider removing or renaming it as _ (revive)
|
|
golangci-lint:
consensus/wal.go#L207
unreachable-code: unreachable code after this statement (revive)
|