-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Run cdk-erigon with cdk config files transparently for the user #88
base: develop
Are you sure you want to change the base?
Conversation
Render the config files in tmp and run erigon passing the path of the config file.
e3b5147
to
d7043e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how to build the rust client, maybe it needs an entry on Makefile?
It's quite straightforward, in Rust there's the concept of "build scripts" arbitrary commands that can be executed at build time, in this case we use this one https://github.com/0xPolygon/cdk/blob/main/crates/cdk/build.rs, it builds
Or just build with:
Better entry on README Updated the readme with new instructions using make |
And parse new optional ExecutionEngine config section
Quality Gate passedIssues Measures |
Description
Using the Rust CLI it's now possible to run cdk-erigon that it's present in system's path in a single step providing only the node config file and the genesis file.
Avoiding the necessity of using multiple configuration files and different configuration for
cdk-node
andcdk-erigon
NOTE: This Rust code is the first iteration into the CLI and can be much improved and refactored in subsequent PRs