Feature/doc rpc #83
Open
Feature/doc rpc #83
+388
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stefan-Ethernal
approved these changes
Sep 18, 2024
vcastellm
reviewed
Sep 26, 2024
| "methods": [ | ||
| { | ||
| "name": "bridge_l1InfoTreeIndexForBridge", | ||
| "summary": "Gets the smalles L1 info tree index in which a given bridge is includded", |
There was a problem hiding this comment.
Suggested change
| "summary": "Gets the smalles L1 info tree index in which a given bridge is includded", | |
| "summary": "Gets the smallest L1 info tree index in which a given bridge is included", |
vcastellm
requested changes
Sep 26, 2024
| "examples": [ | ||
| { | ||
| "name": "example", | ||
| "description": "", |
| }, | ||
| { | ||
| "name": "bridge_injectedInfoAfterIndex", | ||
| "summary": "Gets the smalles L1 info tree index in which a given bridge is includded", |
There was a problem hiding this comment.
Same summary as previous?
| "result": { | ||
| "$ref": "#/components/contentDescriptors/L1InfoTreeLeaf" | ||
| }, | ||
| "examples": [ ] |
| "examples": [ ] | ||
| }, | ||
| { | ||
| "name": "bridge_claimProof", |
There was a problem hiding this comment.
why claimProof and not getProof or just proof? Looks like too specific
vcastellm
reviewed
Sep 26, 2024
| }, | ||
| "Metadata": { | ||
| "title": "metadata", | ||
| "description": "Extra data includded in the bridge", |
There was a problem hiding this comment.
Suggested change
| "description": "Extra data includded in the bridge", | |
| "description": "Extra data included in the bridge", |
vcastellm
reviewed
Sep 26, 2024
| } | ||
| } | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The file can be rendered here