Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adapt kurtosis cdk and fix errors #104

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat: adapt kurtosis cdk and fix errors #104

wants to merge 2 commits into from
+79 −36

Conversation

joanestebanr
Copy link
Contributor

@joanestebanr joanestebanr commented Oct 3, 2024 •
edited
Loading

Description

Last changes on kurtosis-cdk main brach have changed the way that kurtosis answer to ports and also have change some end-points names.

  • Some request of ports return the protocol and another no so the code have been updated to support port with protocol or without (http://127.0.0.1:8023 or 127.0.0.1:8023)
  • Also, to support changing end-point names have include a list of 'end-points' to get the URL / port
  • There was a hardcoded path in config file that have been changed by vars and left the absolute path used by kurtosis as deault value

@joanestebanr joanestebanr changed the base branch from main to develop October 3, 2024 09:47
@joanestebanr joanestebanr changed the title Feature/adapt kurtosis cdk fix errors feat: adapt kurtosis cdk and fix errors Oct 3, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@joanestebanr joanestebanr marked this pull request as ready for review October 3, 2024 10:15
@joanestebanr joanestebanr self-assigned this Oct 3, 2024
vcastellm
vcastellm approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcastellm vcastellm vcastellm approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@joanestebanr joanestebanr

Labels
ci config
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joanestebanr @vcastellm