Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable rollup deployment on any L1 #43

Merged
merged 81 commits into from
Sep 26, 2023
Merged

Enable rollup deployment on any L1 #43

merged 81 commits into from
Sep 26, 2023

Conversation

norswap
Copy link
Member

@norswap norswap commented Sep 26, 2023 •
edited
Loading

Pretty massive changeset that touches every part of the code, and goes beyond just the title.

Some highlights:

  • configuration is now centralized in the Config class in config.py
  • many more things configurable
  • anything in there can be overridden by a TOML file that can be specified with the --config=<path> command line option
  • we can indeed deploy on any L1 ... in theory, only tested in the Linea testnet for now (doesn't work on the Taiko testnet because the OptimismPortal takes more than 6M gas to deploy which is > gas limit, nor on Polygon zkEVM, where it deploys correctly but then fails to get the basefee (???) at L2 genesis generation time
    • probably testing on a few more testnets, including Goerli and Optimism Goerli would be good
  • initial work towards deploying blockscout by @chee-chyuan
  • we can now install Go locally at the right version for the user (that one was painful because there is no Go version manager but you might need an older/newer version than the Optimism codebase)
  • supports all of linux/macOS + arm/intel

Dev/UX changes:

  • added a rollop bash scripts, could help us moving all the python files to a src repo (to be discussed)
  • l2.py split into many components
  • now using "L2 engine" in preference to "L2 execution", though strings, documentations, etc .. should always say "L2 execution engine"
  • moved scripts/install.sh to ./devenv.sh
  • added docs/testing.md explaining how to test on a virgin environment
  • I will be renaming the repo to roll-op after this (redirection should work, but update your origin still!)

norswap and others added 30 commits September 23, 2023 16:29
@norswap
gitignore blockscout and deployments
7df65a0
@norswap
set autopep8 line limit to 100
36f6656
@norswap
reformat
7a122ce
@norswap
split l2-execution.py into multiple files, add commands
2d3cf36
@norswap
op-geth should be installed in setup
a599db7
@norswap
add print
abda69d
@norswap
add L2 CLI config
c61e5e8
@norswap
fold deployments into config
7d98f15
@norswap
refactor l1 / l2 split (contract deployment goes with l2) and add a b…
1e99e2a 
…unch of CLI flags
@norswap
fix bugs
9d19685
@norswap
move things from l1 to l2, avoid import problem by using exec, don't …
b89f1de 
…write l1 timestamp if we don't have L1 genesis file
@norswap
chain ID configuration
83f0d41
@norswap
make a lot of things more generic so that we can deploy on non-local …
9c4fa35 
…chains
@norswap
hackaton config
4dec7d3
@norswap
progress towards deploying on other chains
90ff1ae 
we can now deploy but the system does not work
- it is configured for devnet, with fast & permissive values
- we didn't change the proposer and batcher addresses (using Anvil ones)
@norswap
uncomment hackaton config
53e3e2b
@norswap
refactor config
f6235fe 
- add more config options for the op-node
- automatically derive some paths from config options
- add some config validation logic
@cwkang1998 @norswap
feat: allow devnet config to be read from a file
e79fd89
@norswap
actually generate the deploy config, add production config
d44d6a2
@norswap
parse and import config files, fully generate deploy config
a21d8c7
@norswap
get l1 genesis block working
8c02a4c
@norswap
get unique batch inbox address based on chain ID
0ff1dfc
@norswap
enable running blockscout explorer
467f359
@norswap
simple server that spin rollups
ca892da
@norswap
wait in the server + return address json
4e0a6c7
@norswap
blockscout testing
9609249
@norswap
lint
897f919
@norswap
improve makefile
9e81592
@norswap
format
72475a5
@norswap
regularize clone_repo
7e10b1f
@norswap
check for awk and grep
82866e8
@norswap
comment .gitignore
b9674b9
@norswap
automatically install go if required
7341770
@norswap
allow override any option from config file
b79badc
@norswap
add disclaimer
3c1f9f4
@norswap
add --yes option to install all dependencies
447d834
@norswap
add --clean flag to clean first
d68022a
@norswap
format & lint
50304db
@norswap
move option
5af8b6f
@norswap
add support for configuring L2 engine metrics and ensure ports are di…
7a96db3 
…stinct
@norswap
enable configuring L1 metrics, renumber metrics ports, fix mistakes
64ac630
@norswap
make that help message positively sizzle, and add ability to clean bu…
f53b511 
…ild outputs
@norswap
add bash script
f2505cc
@norswap
update README with usage and update examples
c009ff3
@norswap
python install instructions
f70c2f8
@norswap
support other platform.machine output
78c0762
@norswap
fix
0a0ef74
@norswap
better handle multiple architectures
5c7d6d3
@norswap
fix clone rolling display
7a7a5a4
@norswap
clean the clean
acc9f96
@norswap
revert prod block times
c3c9b25
@norswap
some testing notes
a44b325
@norswap
deploy slowly
3b1ad15
@norswap
Copy link
Member Author

norswap commented Sep 26, 2023

I'm going to insta-merge, no point in reviewing this "diff", might as well just audit the whole repo.

@norswap norswap merged commit 29a103f into master Sep 26, 2023
0 of 2 checks passed
This was referenced Sep 26, 2023
Closed
Open
Closed
@norswap norswap deleted the ns/any-l1 branch September 26, 2023 19:17
@norswap norswap mentioned this pull request Sep 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@norswap @cwkang1998