feat:add autopep8 format #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norswap
approved these changes
Aug 28, 2023
| pip3 install --upgrade autopep8 | ||
| else | ||
| echo "autopep8 is installed" | ||
| fi |
There was a problem hiding this comment.
We probably also want version checks here to avoid random breakage in CI.
l1.py
Outdated
| @@ -174,7 +173,8 @@ def start_devnet_l1_node(paths: OPPaths): | |||
| except Exception: | |||
| running = False | |||
| if running: | |||
| raise Exception("Couldn't start L1 node: server already running at localhost:8545") | |||
| raise Exception( | |||
| "Couldn't start L1 node: server already running at localhost:8545") | |||
There was a problem hiding this comment.
This is weird, this is less than 100 characters long.
|
|
||
| format: ## Run format | ||
| @autopep8 --in-place --recursive . --exclude optimism,op-geth,venv --max-line-length 120 |
There was a problem hiding this comment.
I usually go for 100 as line length. Do you have strong opinions on 120?
Signed-off-by: grapebaba <[email protected]>
…ill not upgrade past
|
Made the fixes, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #28