Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More graceful termination handling #30

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

cygaar
Copy link
Contributor

@cygaar cygaar commented Aug 27, 2023

2 small updates in this PR:

  • The call to wait will fail if the user terminates the program (which triggers kill_all()) because the process is already removed from self.processes
  • When a user terminates the program, the atexit callback is called as well as the termination signal handlers. This ends up triggering kill_all twice and leads to "Terminating background processes..." being output twice. I moved the print statement so it only runs if there are processes to terminate.

@norswap norswap merged commit dc64752 into 0xFableOrg:master Aug 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants