Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix checks missing venv #10

Merged
merged 1 commit into from
Aug 14, 2023
+3 −5
Merged

fix: fix checks missing venv #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@ jobs:
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
- name: Install dependencies and run checks
run: |
source scripts/install.sh
- name: Check with ruff
run: |
make check
4 changes: 2 additions & 2 deletions libroll.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ def run(descr: str, command: str | list[str], **kwargs) -> str:
}
# Seems to return str but I'm getting warnings about it being typed as bytes.
output: str|bytes = subprocess.run(command, **keywords).stdout
if type(output) is str:
if isinstance(output, str):
return output
elif type(output) is bytes:
elif isinstance(output, bytes):
return output.decode("utf-8")
except subprocess.CalledProcessError as err:
raise Exception(f"Failed to {descr}: {err}") from err
Expand Down