Skip to content

Commit

Permalink
fix: fix checks missing venv
Browse files Browse the repository at this point in the history
Signed-off-by: grapebaba <[email protected]>
  • Loading branch information
GrapeBaBa authored and norswap committed Aug 14, 2023
1 parent f067044 commit df22738
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@ jobs:
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
- name: Install dependencies and run checks
run: |
source scripts/install.sh
- name: Check with ruff
run: |
make check
4 changes: 2 additions & 2 deletions libroll.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ def run(descr: str, command: str | list[str], **kwargs) -> str:
}
# Seems to return str but I'm getting warnings about it being typed as bytes.
output: str|bytes = subprocess.run(command, **keywords).stdout
if type(output) is str:
if isinstance(output, str):
return output
elif type(output) is bytes:
elif isinstance(output, bytes):
return output.decode("utf-8")
except subprocess.CalledProcessError as err:
raise Exception(f"Failed to {descr}: {err}") from err
Expand Down

0 comments on commit df22738

Please sign in to comment.