emit connect, disconnect events #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
are the tests passing for you? |
|
I have passed all your available tests. I run tests at local, addition you can check in The Travis CI build result. |
|
It looks like the tests are passing fine, but the test program never terminates. So travis waits 10 minutes then give up. Make sure the test runner is not lingering around after passing the tests. It could be a some scheduled callbacks waiting for something that never happens. |
|
please help me check my commit. is setTimeout cause the problem. I think i didn't add any new schedule callbacks |
|
I will try to find some time to look into it. No guarantee though.
…On Wed, May 31, 2017 at 1:30 PM Dich ***@***.***> wrote:
please help me check my commit. is setTimeout cause the problem. I think i
didn't add any new schedule callbacks
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#91 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AANMjHdH564zA-EXPXVm65Ah-wRo9QyHks5r_c31gaJpZM4NsFAF>
.
|
|
👍 This would be great to have. Apart from the heartbeat error when you try to make a connection and it times out, there's no other notice when the connection is broken... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emit "connect" and "disconnect" event so client can control connect status