diff --git a/tests/test_components.py b/tests/test_components.py index c98588f1..d1ea17d8 100644 --- a/tests/test_components.py +++ b/tests/test_components.py @@ -138,14 +138,17 @@ def test_probability_request(): metadata=ProbabilityMetadata(probability=0.5), ) assert request.get_probability() == 0.5 + assert request.notes is None request = ProbabilityRequest( name="Get with RequestURL object", url=RequestUrl("https://example.com/test"), + notes=["arbitrary", "info"], ) assert request.url == "https://example.com/test" assert request.get_probability() is None + assert request.notes == ["arbitrary", "info"] def test_request(): @@ -154,20 +157,22 @@ def test_request(): Header(name="Content-Type", value="application/x-www-form-urlencoded"), Header(name="Host", value="foo.example"), ] - Request( + request = Request( name="Post Test", url="https://example.com/test", method="POST", body="ZmllbGQxPXZhbHVlMSZmaWVsZDI9dmFsdWUy", headers=headers, ) + assert request.notes is None request = Request( name="Get with RequestURL object", url=RequestUrl("https://example.com/test"), + notes=["arbitrary", "info"], ) - assert request.url == "https://example.com/test" + assert request.notes == ["arbitrary", "info"] def test_job_location(): diff --git a/zyte_common_items/components/request.py b/zyte_common_items/components/request.py index 8a35acdd..de5c1dab 100644 --- a/zyte_common_items/components/request.py +++ b/zyte_common_items/components/request.py @@ -42,6 +42,9 @@ class Request(Item): #: Name of the page being requested. name: Optional[str] = None + #: Arbitrary list of information about the request. + notes: Optional[List[str]] = None + _body_bytes = None @property