parent private property with getter

[JanGalek]

when I have:

<?php
declare(strict_types=1);

namespace App\Model;


abstract class AbstractModel // This need not be a abstract
{
    private $abstractPrivateProperty;

    public $abstractPublicProperty;

    protected $abstractProtectedProperty;

    public function __construct()
    {
        $this->abstractPrivateProperty = 'private';
        $this->abstractPublicProperty = 'public';
        $this->abstractProtectedProperty = 'protected';
    }

    /**
     * @return string
     */
    public function getAbstractPrivateProperty(): string
    {
        return $this->abstractPrivateProperty;
    }
}


class MainModel extends AbstractModel
{
    public $publicProperty;

    private $privateProperty;

    protected $protectedProperty;

    public function __construct()
    {
        $this->publicProperty = 'public';
        $this->privateProperty = 'private';
        $this->protectedProperty = 'protected';

        parent::__construct();
    }
}

and then I try:

<?php
require_once __DIR__ . '/vendor/autoload.php';

$model = new \App\Model\MainModel();
var_dump($model->getAbstractPrivateProperty()); // returns string(7) "private"

$serializer = new \Zumba\JsonSerializer\JsonSerializer();
$serialized = $serializer->serialize($model);
var_dump($serialized); // returns string(193) "{"@type":"App\\Model\\MainModel","publicProperty":"public","privateProperty":"private","protectedProperty":"protected","abstractPublicProperty":"public","abstractProtectedProperty":"protected"}"

/** @var \App\Model\MainModel $back */
$back = $serializer->unserialize($serialized);
var_dump($back);
/** returns
class App\Model\MainModel#11 (6) {
  public $publicProperty =>
  string(6) "public"
  private $privateProperty =>
  string(7) "private"
  protected $protectedProperty =>
  string(9) "protected"
  private $abstractPrivateProperty =>
  NULL
  public $abstractPublicProperty =>
  string(6) "public"
  protected $abstractProtectedProperty =>
  string(9) "protected"
}
*/
var_dump($back->getAbstractPrivateProperty()); // PHP Fatal error:  Uncaught TypeError: Return value of App\Model\AbstractModel::getAbstractPrivateProperty() must be of the type string, null returned

so method getAbstractPrivateProperty returns null after unserialize.

I think its, bug or not ?

[jrbasso]

Thanks for reporting. It seems to be a bug. I will investigate in the next few days.

[JanGalek]

@jrbasso thanks.

[johnCourtier]

Reflection class will only return accessible properties by getProperties method. To get also private properties of parent, you need to getParentClass and check its properties as well (recursively).

[jrbasso]

@johnCourtier Thanks for the tip. If that's the case, it should be easy to incorporate on the lib.