Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network #5

Closed
llorllale opened this issue Jun 25, 2018 · 26 comments
Closed

Network #5

llorllale opened this issue Jun 25, 2018 · 26 comments
Labels
enhancement New feature or request
Milestone

Comments

@llorllale
Copy link
Collaborator

Let's implement Network:

public interface Network extends Iterable<Remote> {
/**
* Push the wallet to the network. The network will select the
* remote node with the highest score (with a minimum of {@code 16}).
* @param wallet The wallet
*/
void push(Wallet wallet);
/**
* Pull a wallet from the network.
* @param id The wallet's {@link Wallet#id() id}
* @return The wallet
*/
Wallet pull(Long id);
}

@llorllale llorllale added the enhancement New feature or request label Jun 25, 2018
@llorllale
Copy link
Collaborator Author

@0crat in

@0crat 0crat added the scope label Jun 25, 2018
@0crat
Copy link
Collaborator

0crat commented Jun 25, 2018

@0crat in (here)

@llorllale Job #5 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Jun 25, 2018

Bug was reported, see §29: +15 point(s) just awarded to @llorllale/z

@llorllale
Copy link
Collaborator Author

@0crat assign @paulodamaso

@0crat
Copy link
Collaborator

0crat commented Jul 3, 2018

@0crat assign @paulodamaso (here)

@llorllale The job #5 assigned to @paulodamaso/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Jul 3, 2018

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @llorllale/z

paulodamaso added a commit to paulodamaso/zold-java-api that referenced this issue Jul 5, 2018
@paulodamaso
Copy link
Contributor

@llorllale Just a doubt here, whitepaper says in page 13 about Fetch action, it is related to Network.pull(id) method, right? It wouldn't be better to keep naming consistency and use fetch for the method name?

@0crat
Copy link
Collaborator

0crat commented Jul 8, 2018

@paulodamaso/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@paulodamaso
Copy link
Contributor

@llorllale Please take a look at this: pull is supposed to get the merged wallets from the network?

@llorllale
Copy link
Collaborator Author

@paulodamaso sorry for the delay - I somehow forgot about this question.

I have doubts myself - please see zold-io/zold#387

paulodamaso added a commit to paulodamaso/zold-java-api that referenced this issue Jul 12, 2018
@paulodamaso
Copy link
Contributor

@0crat wait for #31 merge

@0crat
Copy link
Collaborator

0crat commented Jul 12, 2018

@0crat wait for #31 merge (here)

@paulodamaso The impediment for #5 was registered successfully by @paulodamaso/z

@llorllale llorllale added this to the 1.0 milestone Jul 12, 2018
paulodamaso added a commit to paulodamaso/zold-java-api that referenced this issue Jul 12, 2018
paulodamaso added a commit to paulodamaso/zold-java-api that referenced this issue Jul 12, 2018
paulodamaso added a commit to paulodamaso/zold-java-api that referenced this issue Jul 16, 2018
paulodamaso added a commit to paulodamaso/zold-java-api that referenced this issue Jul 16, 2018
paulodamaso added a commit to paulodamaso/zold-java-api that referenced this issue Jul 19, 2018
paulodamaso added a commit to paulodamaso/zold-java-api that referenced this issue Jul 19, 2018
@0pdd
Copy link
Collaborator

0pdd commented Jul 19, 2018

@llorllale 4 puzzles #38, #39, #40, #41 are still not solved.

@paulodamaso
Copy link
Contributor

@llorllale Merged, please close.

@llorllale
Copy link
Collaborator Author

@paulodamaso thanks

@0crat
Copy link
Collaborator

0crat commented Jul 19, 2018

There is an unrecoverable failure on my side. Please, submit it here:

PID: 4@d96641de-c711-445a-a096-857ab360f1f5, thread: AsyncFlush-4
com.jcabi.xml.StrictXML[124] java.lang.IllegalArgumentException: 1 error(s) in XML document: -1:-1: Duplicate unique value [gh:zold-io/java-api#5] declared for identity constraint of element "verbosity".

0.26.3: CID: 2001511415, Type: "Close job", Author: "llorllale"

@0crat
Copy link
Collaborator

0crat commented Jul 19, 2018

Job gh:zold-io/java-api#5 is not assigned, can't get start time

@0crat
Copy link
Collaborator

0crat commented Jul 19, 2018

@ypshenychka/z please review this job completed by @paulodamaso/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Jul 19, 2018
@0crat
Copy link
Collaborator

0crat commented Jul 19, 2018

The job #5 is now out of scope

@ypshenychka
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented Jul 19, 2018

Order was finished, quality is "good": +46 point(s) just awarded to @paulodamaso/z

@0crat
Copy link
Collaborator

0crat commented Jul 19, 2018

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

@0pdd
Copy link
Collaborator

0pdd commented Jul 29, 2018

@llorllale 4 puzzles #38, #39, #40, #56 are still not solved; solved: #41.

@0pdd
Copy link
Collaborator

0pdd commented Aug 7, 2018

@llorllale 4 puzzles #38, #39, #56, #61 are still not solved; solved: #40, #41.

@0pdd
Copy link
Collaborator

0pdd commented Aug 16, 2018

@llorllale 5 puzzles #38, #39, #61, #79, #80 are still not solved; solved: #40, #41, #56.

@0pdd
Copy link
Collaborator

0pdd commented Dec 4, 2018

@llorllale 8 puzzles #38, #39, #79, #80, #81, #82, #83, #84 are still not solved; solved: #40, #41, #56, #61.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants