Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Mocks with Fakes in tests #42

Open
victornoel opened this issue Jul 21, 2018 · 19 comments
Open

Replace Mocks with Fakes in tests #42

victornoel opened this issue Jul 21, 2018 · 19 comments
Labels
bug Something isn't working scope
Milestone

Comments

@victornoel
Copy link
Contributor

There is a lot of use of Mockito in the tests, it makes it very hard to read and a pain to write.

Using Fakes (see https://www.yegor256.com/2014/09/23/built-in-fake-objects.html) instead would improve the quality of the tests as well as provide a secondary implementation of the main concepts of the Zold java-api, which can only be good for the project.

@0crat
Copy link
Collaborator

0crat commented Jul 21, 2018

@llorllale/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Jul 21, 2018

@victornoel/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@0crat
Copy link
Collaborator

0crat commented Jul 21, 2018

@llorllale/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Jul 21, 2018

@victornoel/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@g4s8
Copy link

g4s8 commented Jul 21, 2018

@0crat status

@0crat
Copy link
Collaborator

0crat commented Jul 21, 2018

@0crat status (here)

@g4s8 This is what I know about this job in CAZUREFND, as in §32:

  • The job #42 is not in scope
  • Job footprint (restricted area)

@llorllale
Copy link
Collaborator

@victornoel I agree. I personally hate using mockito; let's start fixing this while we're still starting.

Let's start by adding Fake implementations to our interfaces where needed.

@llorllale llorllale added the bug Something isn't working label Jul 21, 2018
@0crat 0crat added the scope label Jul 21, 2018
@0crat
Copy link
Collaborator

0crat commented Jul 21, 2018

Job #42 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Jul 21, 2018

Bug was reported, see §29: +15 point(s) just awarded to @victornoel/z

@0crat
Copy link
Collaborator

0crat commented Jul 22, 2018

The job #42 assigned to @carlosmiranda/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@carlosmiranda
Copy link
Contributor

@victornoel will implement this after #49, we can use Score.Default from there to replace some mocks.

@carlosmiranda
Copy link
Contributor

@0crat wait for #49, that PR has some useful code we can use here.

@0crat
Copy link
Collaborator

0crat commented Jul 27, 2018

@0crat wait for #49, that PR has some useful code we can use here. (here)

@carlosmiranda The impediment for #42 was registered successfully by @carlosmiranda/z

@llorllale llorllale added this to the 1.0 milestone Aug 6, 2018
carlosmiranda added a commit to carlosmiranda/java-api that referenced this issue Aug 8, 2018
carlosmiranda added a commit to carlosmiranda/java-api that referenced this issue Aug 8, 2018
@carlosmiranda
Copy link
Contributor

@victornoel see PR #64 please

@victornoel
Copy link
Contributor Author

@carlosmiranda there is also a Mockito usage in TaxesTest :)

carlosmiranda added a commit to carlosmiranda/java-api that referenced this issue Aug 9, 2018
@carlosmiranda
Copy link
Contributor

@victornoel you are better off commenting this (#42 (comment)) in #64 than here. :)

@carlosmiranda
Copy link
Contributor

@0crat refuse

@0crat
Copy link
Collaborator

0crat commented Oct 11, 2019

@0crat refuse (here)

@carlosmiranda The user @carlosmiranda/z resigned from #42, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link
Collaborator

0crat commented Oct 11, 2019

@0crat refuse (here)

@carlosmiranda There is an unrecoverable failure on my side. Please, submit it here:

PID: 4@9b7f0750-f619-44d8-bdbc-fcfc0dc4b9ec, thread: pool-3-thread-2
com.zerocracy.Policy[105] java.lang.IllegalArgumentException: Policy item '6.penalty' not found

0.49.18: CID: f41d22b4-8c0e-4a17-a22a-745ff913f2fc, Type: "Order was canceled"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working scope
Projects
None yet
Development

No branches or pull requests

5 participants