-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Mocks with Fakes in tests #42
Comments
@llorllale/z please, pay attention to this issue |
@victornoel/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot! |
@llorllale/z please, pay attention to this issue |
@victornoel/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot! |
@0crat status |
@victornoel I agree. I personally hate using mockito; let's start fixing this while we're still starting. Let's start by adding |
Job #42 is now in scope, role is |
Bug was reported, see §29: +15 point(s) just awarded to @victornoel/z |
@victornoel will implement this after #49, we can use |
@carlosmiranda The impediment for #42 was registered successfully by @carlosmiranda/z |
@victornoel see PR #64 please |
@carlosmiranda there is also a Mockito usage in |
@victornoel you are better off commenting this (#42 (comment)) in #64 than here. :) |
@0crat refuse |
@carlosmiranda The user @carlosmiranda/z resigned from #42, please stop working. Reason for job resignation: Order was cancelled |
@carlosmiranda There is an unrecoverable failure on my side. Please, submit it here:
0.49.18: CID: f41d22b4-8c0e-4a17-a22a-745ff913f2fc, Type: "Order was canceled" |
There is a lot of use of Mockito in the tests, it makes it very hard to read and a pain to write.
Using Fakes (see https://www.yegor256.com/2014/09/23/built-in-fake-objects.html) instead would improve the quality of the tests as well as provide a secondary implementation of the main concepts of the Zold java-api, which can only be good for the project.
The text was updated successfully, but these errors were encountered: