Creation of wallet

[t-izbassar]

The Wallets interface has a method to create a new Wallet instance. In order to create Wallet we need header information:

• wallet id
• network name
• protocol version
• public RSA key.

I'm not sure, that the Wallets.create() should accept that information through parameters. Who should maintain the ids? From where we will receive it? Through the constructor of WalletsIn()?

[0crat]

@llorllale/z please, pay attention to this issue

[llorllale]

@t-izbassar

• id: My thoughts for now are to make this library generate this randomly and internally somehow.
• network name and protocol version: I just started asking about network name at Why does a Wallet have a 'network'? papers#44. The X-Zold-Protocol header mentioned in RESTful API is linked to the name. Thus it would seem like the wallet's network name is tied to whichever node it's first pushed to. I think more clarification is needed.
• RSA key: Wallets.create should accept the RSA key as parameter, to be provided by the user. After all, wallets may or may not share the same RSA key.

[llorllale]

@t-izbassar can we close this?

[t-izbassar]

@llorllale can you provide links on documentation or commits that are improving the understanding of the project?

[llorllale]

@t-izbassar this is all still a work-in-progress (even the spec itself).

wallet id and protocol version are implementation details that will won't be included in docs.

RSA key will definitely be provided by the user, and it looks like network name will be as well.

This is the documentation we have for now, in this ticket, in the README, in the whitepaper, and in the zold project.

It'll have to do for now.