Skip to content
This repository has been archived by the owner on Jul 11, 2019. It is now read-only.

Status command should report proxies requiring an update #313

Open
spalladino opened this issue Jul 12, 2018 · 1 comment
Open

Status command should report proxies requiring an update #313

spalladino opened this issue Jul 12, 2018 · 1 comment
Labels
dev:good first issue Beginners welcome! kind:enhancement An upgrade or a new feature that improves the system topic:tools Off-chain tooling in general
Milestone

Comments

@spalladino
Copy link
Contributor

Running zos status on a network where a new implementation for a contract was uploaded does not point out if a proxy is using an outdated implementation and should be updated. The output just reads:

Deployed proxies:
- ContractAliasOfProxy at ADDRESS version 0.1.0

If the proxy is using an outdated implementation, point that out in yellow, so the user knows there is a pending upgrade operation.

@spalladino spalladino added kind:enhancement An upgrade or a new feature that improves the system dev:good first issue Beginners welcome! topic:tools Off-chain tooling in general labels Jul 12, 2018
@spalladino spalladino added this to the v2.0.0 milestone Jul 12, 2018
@facuspagnuolo
Copy link
Contributor

Which do you think should be the source of truth in that case? IMO, given that status only considers your local status currently, I'd say it should deduce it from there too.

We may also want to consider the scenario where a new version has been bumped, but the implementation hasn't changed.

@facuspagnuolo facuspagnuolo modified the milestones: v2.0.0, Backlog Oct 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dev:good first issue Beginners welcome! kind:enhancement An upgrade or a new feature that improves the system topic:tools Off-chain tooling in general
Projects
None yet
Development

No branches or pull requests

2 participants