Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with plantuml include and KROKI_PLANTUML_INCLUDE_PATH #1765

Open
michalwronski opened this issue Aug 1, 2024 · 1 comment
Open
Labels
🐞 bug Something isn't working ☕ java Related to Java code

Comments

@michalwronski
Copy link

Hi,

I have local installation of kroki with plantuml libs stored in /home/kroki/include

Kroki is run with the following settings:

  - name: KROKI_PLANTUML_ALLOW_INCLUDE
    value: "true"
  - name: KROKI_PLANTUML_INCLUDE_PATH
    value: "/home/kroki/include"
  - name: KROKI_SAFE_MODE
    value: "SAFE"   

In kroki versions up to 0.20.0 the following works fine:

@startuml JWTInjection
!global $LIB_BASE_LOCATION="tmorin-plantuml-libs-11.1.0"
!include $LIB_BASE_LOCATION/bootstrap.puml   

However, since 0.21.0, I get:
"Error 400: cannot include tmorin-plantuml-libs-11.1.0/bootstrap.puml"
and, as a workaround, I need to use full path:

@startuml JWTInjection
!global $LIB_BASE_LOCATION="/home/kroki/include/tmorin-plantuml-libs-11.1.0"
!include $LIB_BASE_LOCATION/bootstrap.puml

What happened to KROKI_PLANTUML_INCLUDE_PATH in recent versions of kroki?

thanks,
Michal

@ggrossetie
Copy link
Member

We are now using a binary version of PlantUML so I guess we need to find a solution to configure plantuml.include.path from the command line.

String plantUmlIncludePath = config.getString("KROKI_PLANTUML_INCLUDE_PATH");
if (plantUmlIncludePath != null) {
System.setProperty("plantuml.include.path", plantUmlIncludePath);
}

@ggrossetie ggrossetie added 🐞 bug Something isn't working ☕ java Related to Java code labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working ☕ java Related to Java code
Projects
None yet
Development

No branches or pull requests

2 participants