Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bindgen/template): fix shell commands #297

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Sep 10, 2024

  • Perhaps -d is more appropriate here than -e?
  • This is not a Makefile, so if we leave these as $(), we may get an error because there are no commands HOME or PATH.

@yutannihilation yutannihilation merged commit 071b5d0 into yutannihilation:main Sep 10, 2024
15 checks passed
@yutannihilation
Copy link
Owner

Thanks for catching!

@eitsupi eitsupi deleted the fix-shellscript branch September 10, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants