Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject lifetimed struct #283

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Reject lifetimed struct #283

merged 1 commit into from
Jul 29, 2024

Conversation

yutannihilation
Copy link
Owner

Show better error message for #281

error: #[savvy] macro doesn't support lifetime
  --> tests/cases/simple_cases.rs:54:12
   |
54 | struct Foo<'a>(External::Bar<'a>);
   |            ^^

@yutannihilation
Copy link
Owner Author

Note: I'm not sure how type parameters should be treated. It might be allowed, but then it should complicate the code a bit (e.g., can I use Foo<T> for a class name for R?). I'm wondering if it's worth, considering the main scope of savvy is to support simple cases.

@yutannihilation yutannihilation merged commit 08ed0f8 into main Jul 29, 2024
15 checks passed
@yutannihilation yutannihilation deleted the reject-lifetimed-struct branch July 29, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant