Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not honoring auto-commit-interval setting #4

Open
luisobo opened this issue Jun 13, 2016 · 1 comment
Open

Not honoring auto-commit-interval setting #4

luisobo opened this issue Jun 13, 2016 · 1 comment

Comments

@luisobo
Copy link

luisobo commented Jun 13, 2016

Seems like this doc manager is not honoring the autoCommitInterval option. Seems like the the commit method is being called on every update here, on top of the scheduled commit.

Currently, if autoCommitInterval is 0 or null, it will instruct ES to refresh on every index call, which is the desired behavior. If autoCommitInterval is an number N greater than zero, the doc manager will call refresh every N seconds, which is also the desired behavior.

I believe that by simply removing the line I linked the setting will be honored, is this correct?

Thanks

@ShaneHarvey
Copy link
Contributor

Hi @luisobo, the self.commit() is necessary to ensure that we read the most up to date version of the document and apply the changes to that.

You may want to follow this mongo-connector issue which deals with this problem by batching up updates and uses Elastics bulk updates. It looks like it will bring some exciting performance improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants