You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The README claims that plain raw binary keys are accepted, but it's not true.
You can see line 87 to 92, to build the « fixed key » (the key padded), you look for any 0x00 and assume this is the end of a string. This break binary compatibility.
You need to receive the key length from the user, and pad if it's < 16 bytes.
I didn't fixed this issue in a proper way, since keys I use are always 16 bytes. But this is a major issue.
My quick fix is adding two functions (to not break call compatibility):
The README claims that plain raw binary keys are accepted, but it's not true.
You can see line 87 to 92, to build the « fixed key » (the key padded), you look for any
0x00
and assume this is the end of a string. This break binary compatibility.You need to receive the key length from the user, and pad if it's < 16 bytes.
I didn't fixed this issue in a proper way, since keys I use are always 16 bytes. But this is a major issue.
My quick fix is adding two functions (to not break call compatibility):
And call
_bkey
version when passing (safe) binary keys.The text was updated successfully, but these errors were encountered: