Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put cling pragma for loading fftw3 in headers #25

Open
egpbos opened this issue Dec 7, 2017 · 1 comment
Open

Put cling pragma for loading fftw3 in headers #25

egpbos opened this issue Dec 7, 2017 · 1 comment

Comments

@egpbos
Copy link
Member

egpbos commented Dec 7, 2017

As in https://github.com/QuantStack/xtensor-io/blob/a57e3b90ca1025a180c5813c56b8a344ec2d8165/include/xtensor-io/xaudio.hpp#L20-L21, we can put the library loading step in the headers themselves, which saves cling/notebook users from doing it.

@egpbos
Copy link
Member Author

egpbos commented Dec 7, 2017

Also put this in CMakeLists.txt and in xtensor-fftw_config.hpp:

https://github.com/QuantStack/xtensor-io/blob/a57e3b90ca1025a180c5813c56b8a344ec2d8165/CMakeLists.txt#L18

This makes sure the library paths get properly added. Right now, the notebooks are already working, because I'm loading xtensor-io, which also sets all this stuff. Without xtensor-io and without the cling pragma, fftw calls would fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant