Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error #97

Open
guimard opened this issue Jan 10, 2019 · 0 comments
Open

Build error #97

guimard opened this issue Jan 10, 2019 · 0 comments

Comments

@guimard
Copy link

guimard commented Jan 10, 2019

Hello,
I fixed compilation using this:

--- a/node-stringprep.cc
+++ b/node-stringprep.cc
@@ -194,7 +194,7 @@
   if (info.Length() >= 2 && info[0]->IsString() && info[1]->IsInt32())
   {
     String::Value str(info[0]->ToString());
-    int32_t options = info[1]->ToInt32()->Value();
+    int32_t options = Nan::To<int32_t>(info[1]).FromJust();
     UErrorCode error = U_ZERO_ERROR;
     UIDNA *uidna = uidna_openUTS46(options, &error);
     if (U_FAILURE(error))
@@ -252,7 +252,7 @@
   if (info.Length() >= 2 && info[0]->IsString() && info[1]->IsInt32())
   {
     String::Value str(info[0]->ToString());
-    int32_t options = info[1]->ToInt32()->Value();
+    int32_t options = Nan::To<int32_t>(info[1]).FromJust();
     UErrorCode error = U_ZERO_ERROR;
     UIDNA *uidna = uidna_openUTS46(options, &error);
     if (U_FAILURE(error))

Cheers,
Xavier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant