-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage inside scrollview #40
Comments
Hello @xcarpentier, Can you help me to add before and after events when calling the next step. Thank you. |
It's important |
Having the same issue... |
Hi |
Perhaps the I'm studying both libs and only made it work inside
|
xcarpentier#40 - Usage inside scrollview issue fixed
Hello @xcarpentier Please review pull request for this issue , #112 |
Hello @krunal-lw can you provide an example on how to use the changes you made for the scrollview? |
Really thanks krunal for making this PR, this helps me to implement the scrolling and also for bottomsheet. Thanks again |
the above PR must be merge as it has the scrolling handled |
Hello @Haseeba393 How did you implement it? |
Brother I checked @krunal-lw PR and did all the changes he did in his PR and it's working absolutely fine. It's all about to pass the ref of your desired component down to rn-tour package and thruh ref you can do whatever you want to your component. @krunal-lw is doing same thing for scroll view |
Thank you. I'll check it out. |
Your welcome, if you will need any help in implementation, then please let me know. Thanks |
Your welcome @Haseeba393 @christianariola - Let me know if still facing issue to implement with scroll |
Thank you @krunal-lw, I decided to switch to copilot as I needed this feature to be done asap. may package is in js not ts that's why I can't implement it base on your PR |
Can we have have this feature please, thanks |
@Egehanozsoy Hey buddy, you can checkout this version #112, Hope this will help to you. thanks |
Yo @krunal-lw, Thank you for implementing the solution for this issue. I was testing it and I noticed that if the first step of the tour requires scrolling, it won't work properly because of how the ref is set in the state along with the const setCurrentStep = async (key: string, step?: IStep, localScrollRef?: React.RefObject<any>) => {
const actualScrollRef = scrollRef ?? localScrollRef In the const setCurrentStep = async (key: string, step?: IStep, localScrollRef?: React.RefObject<any>) => {
const actualScrollRef = scrollRef ?? localScrollRef
return await new Promise<void>(async (resolve) => {
if (actualScrollRef && step) {
// ... Feel free to implement this on your PR or follow a different path to fix this behavior o/ |
@antoniel Thanks for heads up, I will implement your solution in my PR , Thanks once again, Appreciated |
I love your PR, but I encounter this problem This happens when I reset the navigation, and start the tour again the error occurs. The problem is it happens sometimes. The solution I got is to restart the app to work it again |
Hi guys, how I can use PR from @krunal-lw ? |
Hi @kjethi I can't install with that version but it doesn't work |
Hey @Drzaln , Can you please try yarn add krunal-lw/rn-tourguide I think this will work Or add below line in your package.json file and run yarn install "rn-tourguide": "krunal-lw/rn-tourguide", |
Hi @krunal-lw and also I downgrade the yarn to v1, previously using yarn v3 |
hi @krunal-lw thanks for the major help it works perfectly, but i have another problem ` RCTMeasureLayout ` but when i do the reverse like view -> scrollview eveything works fine , any solutions for that ? example
i want it to work that way but i am getting the specified error |
Did you find any solution for this? I'm also facing the same issue. |
Does anyone have experience with how to use it inside a scrollview?
It highlights the components outside the view. So even if I scroll down it is not visible.
I also tried a walkaround by using the
handleOnStepChange()
callback tostop()
the animation after the first step then scroll down my view andstart(step)
again at the desired step. But it's very ugly and also doesn't work, the animation does not start again.The text was updated successfully, but these errors were encountered: