Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Documents #26

Open
sourish-cmi opened this issue Aug 23, 2022 · 6 comments
Open

Design Documents #26

sourish-cmi opened this issue Aug 23, 2022 · 6 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@sourish-cmi
Copy link
Collaborator

  1. Current documentation removes all the examples I provided in the initial documents. But those initial examples had to remove because it was taking too much time to compile - how can we bring those examples back?

  2. We need to accommodate the case studies that data scientists are making as part of the CRRao package. How can we bring those case studies as part of the documentation?

@codetalker7
Copy link
Member

For 1, we can add the old examples (just the code, we won't run that code during the documentation build to save time) to the docstrings for the corresponding functions. This is what Shouvik is doing right now.

In the current documentation, there is a guide (https://xkdr.github.io/CRRao.jl/dev/man/guide/) in which there are two examples; one for Frequentist and one for Bayesian. For other examples, users should be able to just directly go to the API docs for whatever model they want to use, and see an example for that.

@ajaynshah
Copy link
Member

a. We should study Zelig for documentation design.

b. In my opinion (not deeply thought, just writing here), there is a need for 3 kinds of documentation. 1. Unix man pages: perfect, terse, precision above all. 2. A gentle introduction that gets a person started: from 0 until the point till they are able to read the man pages. 3. A JSS article which shows objectives, design philosophy, comparisons with other systems (in this case Zelig), critical elements of thought on the design, demonstrate correctness, measure performance, discuss future roadmap.

@sourish-cmi
Copy link
Collaborator Author

  • I would like all examples for Frequestist cases to be back.
  • For Bayesian cases, keep only Ridge and Laplace prior cases with sim_size=501

@codetalker7
Copy link
Member

PR #28 (review) adds back all the examples to the respective docstrings, both for the frequentist models and the bayesian models.

@sourish-cmi
Copy link
Collaborator Author

On a different note - I thought - we could put all the examples and more detail on the "Wiki" (https://github.com/xKDR/CRRao.jl/wiki)

Keep the documentation clean and tight.

What do you think?

@ajaynshah @ayushpatnaikgit @codetalker7 @ShouvikGhosh2048

@ayushpatnaikgit
Copy link
Member

We have added all the examples under API. They'll also be available to the user through the REPL.

@sourish-cmi sourish-cmi added the documentation Improvements or additions to documentation label Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants