Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send announcement notifications on start date #74

Open
Gerzer opened this issue Sep 12, 2023 · 1 comment · May be fixed by #90
Open

Send announcement notifications on start date #74

Gerzer opened this issue Sep 12, 2023 · 1 comment · May be fixed by #90
Assignees
@chijioke01
Labels
enhancement New feature or request

Comments

@Gerzer
Copy link
Collaborator

Gerzer commented Sep 12, 2023

Currently, announcement notifications are sent via APNS as soon as the announcement is submitted to the server, even if that announcement’s start date is in the future. We should instead schedule up a job that sends the notifications at the right time on the start date if that date is far enough in the future (an hour or longer, perhaps?).
@Gerzer Gerzer added the enhancement New feature or request label Sep 12, 2023
@Gerzer
Copy link
Collaborator Author

Gerzer commented Sep 12, 2023 •
edited
Loading

We should also set the expiration date in the APNSAlertNotification structure to the announcement’s end date, taking into account its schedule type.

@chijioke01 chijioke01 self-assigned this Feb 23, 2024
@chijioke01 chijioke01 linked a pull request Mar 15, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chijioke01 chijioke01

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Announcement parsing wtg/Shuttle-Tracker-Server
2 participants
@Gerzer @chijioke01