Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Application Branding Resolver Calling Method #625

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

dhaura
Copy link
Contributor

@dhaura dhaura commented Jun 20, 2024

Purpose

  • The resolveApplicationBrandingPreference method is now deprecated and instead, resolveBrandingPreference method is used with the type as "APP".

Related PRs

@dhaura dhaura marked this pull request as draft June 20, 2024 14:55
AnuradhaSK
AnuradhaSK previously approved these changes Jul 1, 2024
@dhaura dhaura marked this pull request as ready for review July 15, 2024 04:52
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/9933908942

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/9933908942
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/9933908942

@dhaura dhaura merged commit 56e96aa into wso2:master Jul 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants