Remove keystore module. #4895
Merged
Remove keystore module. #4895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
To minimize the external impact from this change, instead of removing the OSGi services and SOAP services, we can update the implementation to invoke the new service you have introduced in the kernel. And we can deprecate these services as well. |
mpmadhavig
force-pushed
the
remove-keystore-module
branch
from
b53a6df
to
0e8e9bc
Compare
mpmadhavig
merged commit 0f208b4
into
wso2:feature-remove-registry-from-keystore
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe
This effort will remove the keystore package from framework security-mgt module and move that to the kernel. The decision has been taken to do so was due to a cyclic dependency between the keystore package and the keyStoreAdmin in carbon-core.
Related issues