Improve federated idp initiated logout for multiple IDP sessions #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/8819083423
ThaminduR
approved these changes
Apr 25, 2024
ThaminduR
reviewed
Apr 25, 2024
| @@ -346,6 +369,10 @@ protected void validateIssuerClaim(JWTClaimsSet claimsSet) throws LogoutClientEx | |||
| */ | |||
| protected void validateAudience(List<String> aud, IdentityProvider idp) throws LogoutClientException { | |||
|
|
|||
| // Validate audience is skipped for the resident IDP. | |||
| if (RESIDENT_IDP_RESERVED_NAME.equals(idp.getIdentityProviderName())) { | |||
There was a problem hiding this comment.
Let's add the audience validation for the resident idp tokens as well. Need to check the complexity of doing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
$subject